[core] Support timestamp field type in record level expire #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Oct 31, 2024
| && field.type() instanceof BigIntType) | ||
| || (timeFieldType == CoreOptions.TimeFieldType.MILLIS_LONG | ||
| && field.type() instanceof BigIntType))) { | ||
| if (!isValidateFieldType(timeFieldType, field)) { | ||
| throw new IllegalArgumentException( | ||
| String.format( | ||
| "The record level time field type should be one of SECONDS_INT,SECONDS_LONG or MILLIS_LONG, " |
There was a problem hiding this comment.
The record level time field type should be one of SECONDS_INT, SECONDS_LONG, MILLIS_LONG or TIMESTAMP, but time field type is %s, field type is %s.
|
|
||
| private static boolean isValidateFieldType( | ||
| CoreOptions.TimeFieldType timeFieldType, DataField field) { | ||
| return ((timeFieldType == CoreOptions.TimeFieldType.SECONDS_INT |
There was a problem hiding this comment.
DataType dataType = field.type();
| long millis = System.currentTimeMillis(); | ||
| Timestamp timestamp1 = Timestamp.fromEpochMillis(millis - 60 * 1000); | ||
| Timestamp timestamp2 = Timestamp.fromEpochMillis(millis); | ||
| Timestamp timestamp3 = Timestamp.fromEpochMillis(millis + 60 * 1000); |
There was a problem hiding this comment.
Add a ut to test LocalZonedTimestampType?
| } | ||
|
|
||
| @Test | ||
| public void test() throws Exception { |
|
Please add Purpose of this pr. |
addressed, thanks for your review @wwj6591812 |
JingsongLi
reviewed
Nov 4, 2024
| @@ -1351,7 +1351,7 @@ public class CoreOptions implements Serializable { | |||
| .enumType(TimeFieldType.class) | |||
| .defaultValue(TimeFieldType.SECONDS_INT) | |||
There was a problem hiding this comment.
Can we just set this to AUTO? If the field is timestamp, we don't need to set this option.
There was a problem hiding this comment.
AUTO maybe cannot adapt to all types, just added detailed log.
hang8929201
pushed a commit
to hang8929201/paimon
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Record level expiration supports timestamp type and timestamp_ltz type.
Tests
API and Format
Documentation